-
-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: expand Prettier glob to all files #701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nschonni Thanks for the contribution!
Pulled. npm test
and npm run lint
both pass for me. CI checks are passing.
I don't have strong opinions about YAML formatting, but I know indent levels in YAML are importantish. The changes here appear to be benign, and I'm a fan of enforcing consistent formatting so this seems like a win.
@ctavan If this looks good to you, go ahead and merge.
I could override the Prettier config to use double quotes for Yaml files to reduce the diff, if that's preffered |
Not necessary (at least, not on my account). I'm partial to single-quotes. |
This looks good! I've merged the PR that adds the ability to run bundlewatch and browser tests on branches, would you mind rebasing? |
Rebased, but you'll need to add a |
Thanks a lot! Bundlewatch returns an error, we haven't reconfigured it for the I may find time to fix this later today, but if you have a minute, you could try configuring the ci option in https://github.com/uuidjs/uuid/blob/main/bundlewatch.config.json in accordance with https://bundlewatch.io/#/reference/configuration?id=ci |
@broofa I think you might need to remove and re-add the label to see the bundlewatch job triggered |
Looks like the build worked, but there is still a dangling one for bundlewatch API check |
Hmm, bundlewatch did run correctly now (https://github.com/uuidjs/uuid/actions/runs/4504866899/jobs/7929883055?pr=701) but still doesn't report status… |
Might be this bundlewatch/bundlewatch#220 (comment) |
Wanna give it a try? |
The single quote glob expansion doesn't work on Windows. Instead of changing to the
\"
escapted double quote, I just used the dot expansion to run on everything and made the Husky hook match