-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tail: fix issue #6543 (--pid when reading from stdin) #6582
Open
just-an-engineer
wants to merge
24
commits into
uutils:main
Choose a base branch
from
just-an-engineer:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
addf7b5
Added in logic in tail to be able to follow stdin when a PID is speci…
03b3bf1
Add test to follow file until specified PID dies. Remove comment
05262b6
Merge branch 'uutils:main' into main
just-an-engineer aa8f2af
Improve pid test for tail
bbefeba
cargo fmt
cbbef09
Increase assert is alive in test_following_with_pid in test_tail to 1…
520e8b8
Added in logic in tail to be able to follow stdin when a PID is speci…
b242461
Add test to follow file until specified PID dies. Remove comment
465ef45
Improve pid test for tail
731e4e1
cargo fmt
fed2705
Increase assert is alive in test_following_with_pid in test_tail to 1…
a4cc3a7
Changed test_following_with_pid to read from a file instead of stdio:…
e7d1c0b
Merge branch 'main' of https://github.com/just-an-engineer/coreutils …
1ade9ac
Merge branch 'main' into main
just-an-engineer 0811fea
Apple doesn't currently work for passing in files to stdin
73bbd9a
Merge branch 'main' of https://github.com/just-an-engineer/coreutils …
bcc144b
Got test_following_with_pid to work on Windows
just-an-engineer b8c5bc8
is_not_alive -> is_alive in test_following_with_pid
b120a56
Fixed `is_not_alive` issue on linux by reaping child sleep process, o…
8c5097a
Add missed `mut` to windows sleep_command in test_tail for test_follo…
just-an-engineer 1f0d9d5
Fixed formatting, spelling, and made clippy happy
98c546f
Merge branch 'main' into main
sylvestre 09e2610
Merge branch 'main' into main
just-an-engineer 59aea7e
Merge branch 'main' into main
sylvestre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add details why it isn't working on other os
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I'm sorry I didn't answer for over a month. I remember seeing your message shortly after you wrote it, but I don't remember after that, if I got busy or what. I had thought I had written something for it, but I guess not.
I think I had known at one point, but I don't have an Apple device to test on, and so currently I don't actually know.
I'll reach out to a friend with one and see if they can figure it out or not, and try to update this thread or the code accordingly.