Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lscpu: simplify signature of CpuInfo::new() #225

Merged
merged 1 commit into from
Feb 17, 2025
Merged

lscpu: simplify signature of CpuInfo::new() #225

merged 1 commit into from
Feb 17, 2025

Conversation

cakebaker
Copy link
Contributor

This PR removes the third param of CpuInfo::new() because we always pass None as value.

alxndrv
alxndrv approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@alxndrv alxndrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up

@sylvestre sylvestre merged commit f7b663a into uutils:main Feb 17, 2025
13 checks passed
@codecov Codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (748bbf8) to head (68706fb).
Report is 34 commits behind head on main.

Additional details and impacted files 
@@     Coverage Diff     @@
##   main   #225   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cakebaker cakebaker deleted the lscpu_simplify_cpuinfo_new branch February 18, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxndrv alxndrv alxndrv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cakebaker @alxndrv @sylvestre