Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up Dockerfile for running the R script #46
Set up Dockerfile for running the R script #46
Changes from all commits
a7d85c1
893f093
8cc6bac
f3650aa
efdc638
1efafee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you move this line below the
install_local
we should be able to change files in the ./R folder without having to reinstall the dependenciesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a great point, i should move this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried this and realized that moving
install_local()
beforeCOPY R ./R
doesn’t work correctly, as thebiodiversityhorizons
package was missing and gave the error:Since
install_local()
was running before the R/ folder was copied, the package source code wasn’t available at the time of installation, so it wasn’t installed inside Docker.Hence, we have to
copy R ./R
beforeinstall_local()
so that the package source code is available before installation, ensuring that it is correctly installed inside Docker. Hope that makes sense :)