Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use volume mounts for input/output of data #67

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

carlosgjs
Copy link
Member

Using volumes is required for the container to read data from the host system and write the results out. Changes:

  • Use ENTRYPOINT to ensure the container always runs the script (CMD sets overridable arguments)
  • Split/two-stage the copy of the code and the calls to install_local to make builds faster when changing the code.
  • Add run_container.sh script for making it easy to run the container with the right volume mounts.

Example test to verify parameters get passed correctly:

./run_container.sh ./data-raw ./output multisession 8
INFO [2025-02-02 01:20:25] Computing thermal limits for each species using 8 workers and a 'multisession' parallelization plan.

And output generated in the host machine: ./output/res_final.rds

Issue: #61

@carlosgjs carlosgjs linked an issue Feb 2, 2025 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.80%. Comparing base (bfd269a) to head (29e2a5b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #67   +/-   ##
=====================================
  Coverage   0.80%   0.80%           
=====================================
  Files          6       6           
  Lines        124     124           
=====================================
  Hits           1       1           
  Misses       123     123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IshikaKhandelwal IshikaKhandelwal merged commit 4836201 into main Feb 3, 2025
7 checks passed
IshikaKhandelwal added a commit to IshikaKhandelwal/biodiversity-horizons that referenced this pull request Feb 4, 2025
* Use volume mounts for input/output of data

* Fix pre-commit hook issues

---------

Co-authored-by: Ishika <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Enable Persistent Volume Mounting
3 participants