Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: cleanup duplicate docker files. #97

Merged
merged 6 commits into from
Feb 28, 2025

Conversation

anujsinha3
Copy link
Collaborator

#96 build: cleanup duplicate docker files.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.80%. Comparing base (4d09366) to head (af5690b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #97   +/-   ##
=====================================
  Coverage   0.80%   0.80%           
=====================================
  Files          6       6           
  Lines        124     124           
=====================================
  Hits           1       1           
  Misses       123     123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@IshikaKhandelwal IshikaKhandelwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the current workflow ensure that the Docker image is built for Linux compatibility (since we need to pull it into Apptainer)?

Previously, I used to run this command locally to ensure compatibility:

docker buildx build --platform linux/amd64,linux/arm64 -t ghcr.io/uw-ssec/biodiversity-horizons:latest --push .

Currently, this file does not specify the --platform flag. Should we modify the Build and Push Docker Image step to explicitly include:

platforms: linux/amd64,linux/arm64

@anujsinha3
Copy link
Collaborator Author

anujsinha3 commented Feb 28, 2025

Does the current workflow ensure that the Docker image is built for Linux compatibility (since we need to pull it into Apptainer)?

Previously, I used to run this command locally to ensure compatibility:

docker buildx build --platform linux/amd64,linux/arm64 -t ghcr.io/uw-ssec/biodiversity-horizons:latest --push .

Currently, this file does not specify the --platform flag. Should we modify the Build and Push Docker Image step to explicitly include:

platforms: linux/amd64,linux/arm64

currently pushing with only amd64 until I figure a workaround for arm64 build slowness

@anujsinha3 anujsinha3 merged commit 339cc69 into uw-ssec:main Feb 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants