-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: cleanup duplicate docker files. #97
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
=====================================
Coverage 0.80% 0.80%
=====================================
Files 6 6
Lines 124 124
=====================================
Hits 1 1
Misses 123 123 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the current workflow ensure that the Docker image is built for Linux compatibility (since we need to pull it into Apptainer)?
Previously, I used to run this command locally to ensure compatibility:
docker buildx build --platform linux/amd64,linux/arm64 -t ghcr.io/uw-ssec/biodiversity-horizons:latest --push .
Currently, this file does not specify the --platform flag. Should we modify the Build and Push Docker Image step to explicitly include:
platforms: linux/amd64,linux/arm64
currently pushing with only amd64 until I figure a workaround for arm64 build slowness |
#96 build: cleanup duplicate docker files.