Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seb/volunteer signed up model - all inclusive #11

Closed
wants to merge 32 commits into from
Closed

Seb/volunteer signed up model - all inclusive #11

wants to merge 32 commits into from

Conversation

sebmendoza
Copy link
Contributor

Notion ticket link

Create a volunteers signed up model

Implementation description

  • Created data model for a user who is signed up

Steps to test

  1. Make a postman request to the api endpoint: '/users/volunteers-signed-up and check mongodb. There are special changes needed to make this work. It is detailed in the notion ticket.

What should reviewers focus on?

  • Any feedback?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

sebmendoza and others added 18 commits October 5, 2023 19:28
@sebmendoza
testing pushing branch
94f82f7
@vaaranan-y
[volunteer-signup-request] - added volunteer_signup model to prisma
aac53ef
@ayush110
init-commit
07dc06f
@ya5er
Created volunteer sign up model
b6c7846
@ya5er
Added Status type
58d0fc2
@ya5er
Added volunteer sign up schema
474c97c
@vaaranan-y
Merge branch 'vaaranan-yaser/create-volunteer-signup-request-model' of …
21d5c0a 
…https://github.com/uwblueprint/abtc into vaaranan-yaser/create-volunteer-signup-request-model
@vaaranan-y
minor fix to status type
c3274e7
@vaaranan-y
Minor fix to prisma schema
e23e072
@vaaranan-y
Minor fix to TS model
c3983b4
@sebmendoza
minor user service change
707a344
@sebmendoza
merge conflicts
51c4e6e
@sebmendoza
another merge conflict
462c97d
@vaaranan-y
Merge branch 'master' into vaaranan-yaser/create-volunteer-signup-req…
3e2e234 
…uest-model
@vaaranan-y
Made admin_id a related field (to user id)
bf6cc99
@vaaranan-y
added status enum
c691605
@vaaranan-y
Removed mongoose model for volunteer signup
97154c1
@vaaranan-y
Removed unnecessary mongoose enum
42eaad7
@anmoltyagi1
Copy link
Member

since you already did all the logic, just move all the logic in the correct format of the next ticket if you can

kevinouyang1
kevinouyang1 reviewed Nov 2, 2023
View reviewed changes
backend/typescript/services/implementations/userService.ts
@@ -346,6 +346,7 @@ class UserService implements IUserService {
throw error;
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take out empty line for linting!

@sebmendoza sebmendoza changed the title Seb/volunteer signed up model Seb/volunteer signed up model - all inclusive Nov 17, 2023
@sebmendoza sebmendoza closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinouyang1 kevinouyang1 kevinouyang1 left review comments

@anmoltyagi1 anmoltyagi1 anmoltyagi1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sebmendoza @anmoltyagi1 @kevinouyang1 @vaaranan-y @ayush110 @ya5er