Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create volunteer signup request model (Vaaranan/Yaser) #7

Merged

Conversation

vaaranan-y
Copy link
Contributor

@vaaranan-y vaaranan-y commented Oct 12, 2023

Notion ticket link

Create a volunteer signup request model

Implementation description

  • Created a model for the VolunteerSignUp entity, by creating an entry in the prisma schema, and its own TypeScript model
  • Added a new type to set the status of a VolunteerSignUp entity

Steps to test

  1. Likely cannot be black-box tested (just a model) but model can be verified to match up with Figma design (https://www.figma.com/file/99N86wIdlsQuQ2Jat9kv0k/ABTC-Architecture-Design?type=whiteboard&node-id=1-34&t=GE7nuttz58QlLy4P-0) and checking parameters for model in backend/typescript/models/volunteerSignUp.model.ts and backend/typescript/prisma/schema.prisma match up appropriately

What should reviewers focus on?

  • We probably want to make sure that the attributes of our model are correctly defined, and if there is anything we are missing (i.e. first name, last name, etc.)

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

backend/typescript/prisma/schema.prisma Outdated Show resolved Hide resolved
backend/typescript/types.ts Outdated Show resolved Hide resolved
backend/typescript/models/volunteerSignUp.model.ts Outdated Show resolved Hide resolved
@@ -35,6 +36,17 @@ model serviceRequest {
requestType ServiceRequestType
}

model volunteerSignUp {
id String @id @default(auto()) @map("_id") @db.ObjectId
v Int @map("__v")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go, small thing - can you take out this v - we don't need it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@anmoltyagi1 anmoltyagi1 merged commit 5a61cec into master Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants