Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide review button on non-review page #261

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

jfdoming
Copy link
Collaborator

@jfdoming jfdoming commented Jul 4, 2023

Ticket link

Closes #260

Implementation description

  • Hide button when any non-review tab is selected

Steps to test

  1. View dashboard.
  2. Select the creators tab.
  3. See that the button is hidden.

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have run docker-compose up and my project compiled
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Visit the preview URL for this PR (updated for commit ef8541d):

https://ccbc-95e66--pr261-julian-hide-review-b-xk88b96f.web.app

(expires Wed, 13 Sep 2023 00:04:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c378380023717371c81e2542a3b308a673eeb7f6

@jfdoming jfdoming force-pushed the julian/hide-review-button-on-non-review-page branch from acbf464 to ef8541d Compare September 5, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide review button on creator page in admin dashboard
1 participant