Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Case overview children component #195

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Case overview children component #195

wants to merge 15 commits into from

Conversation

kevinchen220
Copy link
Contributor

@kevinchen220 kevinchen220 commented Jul 7, 2023 •
edited by omeradeel26
Loading

Notion ticket link

Case Overview Children Component Backend

Implementation description

  • creating/editing children information in case overview section

Steps to test

  1. Test that children can be created or edited through caseoverview page. Refresh page to verify that changes are being saved in backend and not just through the state

What should reviewers focus on?

  • Re-factoring of provider and daycare model is required to finish editing/saving of child
  • Code is merged with Jenny's caregiver branch to use 'CasePromptBox'

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@github-actions
Copy link

github-actions bot commented Jul 7, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit ef83b1e):

https://childrens-aid-society--pr195-kevinc-caseoverviewc-nbtopqqf.web.app

(expires Sat, 11 Nov 2023 21:53:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 93f6cb7bff946a1edd29d684408e6d31442cf0b1

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 2, 2023
View reviewed changes
backend/python/app/rest/child_routes.py
return jsonify(list(new_children)), 200

except Exception as error:
return jsonify(error), 400

Check warning

Code scanning / CodeQL

Information exposure through an exception

[Stack trace information](1) flows to this location and may be exposed to an external user.
backend/python/app/rest/child_routes.py
undos.append((daytime_response,"delete_daytime_contact", daytime_response.id))
except Exception as error:
run_undos()
return jsonify(error), 400

Check warning

Code scanning / CodeQL

Information exposure through an exception

[Stack trace information](1) flows to this location and may be exposed to an external user.
backend/python/app/rest/child_routes.py Outdated
undos.append((child_service, "delete_child", child_response.id))
except Exception as error:
run_undos()
return jsonify(error), 400

Check warning

Code scanning / CodeQL

Information exposure through an exception

[Stack trace information](1) flows to this location and may be exposed to an external user.
backend/python/app/rest/child_routes.py Fixed Show fixed Hide fixed
backend/python/app/rest/child_routes.py Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 2, 2023
View reviewed changes
backend/python/app/rest/caregiver_routes.py
caregivers = caregiver_service.get_all_caregivers()
return jsonify(list(map(lambda user: user.__dict__, caregivers))), 200
except Exception as error:
return jsonify(error), 400

Check warning

Code scanning / CodeQL

Information exposure through an exception

[Stack trace information](1) flows to this location and may be exposed to an external user.
backend/python/app/rest/caregiver_routes.py
return jsonify(updated_caregiver.__dict__), 200

except Exception as error:
return jsonify(str(error)), 400

Check warning

Code scanning / CodeQL

Information exposure through an exception

[Stack trace information](1) flows to this location and may be exposed to an external user.
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 3, 2023
View reviewed changes
backend/python/app/rest/child_routes.py Outdated
# undos.append((child_service, "delete_child", child_response.id))
except Exception as error:
# run_undos()
return jsonify(error),400

Check warning

Code scanning / CodeQL

Information exposure through an exception

[Stack trace information](1) flows to this location and may be exposed to an external user.
@omeradeel26 omeradeel26 changed the title Kevin c/case overview children component Case overview children component Nov 4, 2023
@omeradeel26 omeradeel26 force-pushed the KevinC/CaseOverviewChildrenComponent branch from 7fae671 to ef83b1e Compare November 4, 2023 21:50
@omeradeel26 omeradeel26 requested a review from a team November 4, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenzhu1 bowenzhu1 Awaiting requested review from bowenzhu1

@jess94yng jess94yng Awaiting requested review from jess94yng

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinchen220 @omera26