Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vihaan anant/ calendar functionality #11

Closed
wants to merge 2 commits into from

Conversation

anantduggal
Copy link
Collaborator

@anantduggal anantduggal commented Jun 21, 2024

Notion ticket link

Calendar Absence Creation and Deletion

Implementation description

  • Added Calendar Functionality -> creating and deleting events on a calendar
  • Multiple events are allowed.
  • Managed buttons instead of onclick events
  • Stored in dynamic memory

Steps to test

  1. Multiple Added Events shows up on the specified date
  2. All events are able to be deleted with a "delete" button right under it

What should reviewers focus on?

  • Calendar & Input form are being held in dynamic memory, to avoid hydration UI issues.

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@ChinemeremChigbo
Copy link
Member

ChinemeremChigbo commented Jun 23, 2024

Please ensure that your branch passes the review checks. You may need to run eslint to lint everything.
image

If your PR is still in progress, please "Convert to a draft"
image

@VJagiasi VJagiasi marked this pull request as draft July 1, 2024 19:45
@VJagiasi VJagiasi closed this Jul 5, 2024
@VJagiasi VJagiasi deleted the vihaan-anant/-calendar-functionality branch July 5, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants