Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate APIs to app/api, create @utils/prisma and fixed OpenSSL Bug #52

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ludavidca
Copy link
Collaborator

@ludavidca ludavidca commented Dec 27, 2024

Notion ticket link

Consolidate APIs to app/api

Implementation description

  • Moved Send Email and users api from pages/api to app/api
  • Made changes to code to ensure compatibility with NextJs 13
  • Tested and ensured feature functionality is not diminished.

Additional Changes:

  • Fix Open SSL error on main (This was an error that I ran into when I started my docker image, where prisma was unable to find the openssl installation): prisma:warn Prisma failed to detect the libssl/openssl version to use, and may not work as expected. Defaulting to "openssl-1.1.x".
  • Add @utils/prisma instead of relative routing for ease of use (there were too many ../../ in the codebase)

Steps to test

  1. Ensure that manage.tsx still functions as normal
  2. Ensure that email.tsx can send emails
  3. Ensure that profile.tsx works when logged in

What should reviewers focus on?

  • Ease of Understanding
  • Things are working

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sistema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 0:46am

Copy link
Collaborator

@135ze 135ze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants