Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docker argument order #55

Merged
merged 1 commit into from
Feb 1, 2025
Merged

update docker argument order #55

merged 1 commit into from
Feb 1, 2025

Conversation

135ze
Copy link
Collaborator

@135ze 135ze commented Jan 29, 2025

NOTICKET

Implementation description

it's docker compose up --build not docker compose build --up. See line 89.

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@vercel Vercel
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sistema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 1:48am

@135ze 135ze requested review from a team and ColinToft and removed request for a team January 29, 2025 01:48
ChinemeremChigbo
ChinemeremChigbo approved these changes Feb 1, 2025
View reviewed changes
Copy link
Member

@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChinemeremChigbo ChinemeremChigbo merged commit aa71ea2 into main Feb 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChinemeremChigbo ChinemeremChigbo ChinemeremChigbo approved these changes

@ColinToft ColinToft Awaiting requested review from ColinToft ColinToft was automatically assigned from uwblueprint/sistema

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@135ze @ChinemeremChigbo