Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add necessary changes to support connecting to Heroku postgres #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simhonchourasia
Copy link
Collaborator

Notion ticket link

Heroku Postgres: Look into Hosting a Postgres DB on Heroku & Backend

Implementation description

  • Change migrations to work with sequelize from bash
  • Use ssl for heroku connection to postgres db
  • Use different config and env files

Steps to test

  1. Use command heroku pg:psql postgresql-solid-50144 --app sleepy-caverns-02101 to connect to the database and check it out
  2. Make a graphql request like the following:
query {
    dashboardById(id: 2) {
        reviewerEmail
    }
}

at https://sleepy-caverns-02101-edcc7706ba5e.herokuapp.com/graphql (link might be outdated).

What should reviewers focus on?

  • Currently firebase authentication doesn't quite work for this, as seen in certain endpoints (such as most of the user queries)

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant