Skip to content

Commit

Permalink
Address PR feedback
Browse files Browse the repository at this point in the history
Add `const` to dependency where needed

Signed-off-by: nscipione <[email protected]>
  • Loading branch information
s-Nick committed Nov 29, 2024
1 parent a460215 commit 4469fcc
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ When USM pointers are used as input to, or output from, a oneMath routine, it be

To help the calling application, all oneMath routines with at least one USM pointer argument also take an optional reference to a list of *input events*, of type ``std::vector<sycl::event>``, and have a return value of type ``sycl::event`` representing computation completion::

sycl::event math::domain::routine(..., std::vector<sycl::event> &in_events = {});
sycl::event math::domain::routine(..., const std::vector<sycl::event> &in_events = {});

The routine shall ensure that all input events (if the list is present and non-empty) have occurred before any USM pointers are accessed. Likewise, the routine's output event shall not be complete until the routine has finished accessing all USM pointer arguments.

Expand Down

0 comments on commit 4469fcc

Please sign in to comment.