Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Remove single_pass_scan target duplicate #1796

Merged
merged 1 commit into from
Aug 27, 2024
Merged

[test] Remove single_pass_scan target duplicate #1796

merged 1 commit into from
Aug 27, 2024

Conversation

dmitriy-sobolev
Copy link
Contributor

The PR removes a single_pass_scan target, which is a duplicate of single_pass_scan_dpwi8_wgs256_uint32.
The main motivation is to have all the targets under build-scan-kt-tests/run-scan-kt-tests umbrellas for easier test automation.

@dmitriy-sobolev dmitriy-sobolev added the test Test only Change label Aug 27, 2024
@dmitriy-sobolev
Copy link
Contributor Author

@adamfidel, let me know if you prefer adding single_pass_scan into build-scan-kt-tests/run-scan-kt-tests. I am slightly inclined towards simply removing single_pass_scan, but I may be persuaded to follow the other way.

@adamfidel
Copy link
Contributor

The single_pass_scan target was mainly used as a convenience while developing and debugging the scan kernel template. As it is redundant and not strictly necessary, I am not opposed to removing it.

timmiesmith
timmiesmith approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@timmiesmith timmiesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@dmitriy-sobolev dmitriy-sobolev merged commit fbd529c into main Aug 27, 2024
22 checks passed
@dmitriy-sobolev dmitriy-sobolev deleted the dev/dmitriy-sobolev/kt-scan-target branch August 27, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmiesmith timmiesmith timmiesmith approved these changes

@adamfidel adamfidel Awaiting requested review from adamfidel

Assignees
No one assigned
Labels
test Test only Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmitriy-sobolev @adamfidel @timmiesmith