Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix to avoid __out for MSVC #2034

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Conversation

danhoeflinger
Copy link
Contributor

__out is a macro in Microsoft C++ SAL (Source Annotation Language).
We cant use it as a variable name. Causes compiler errors for microsoft platforms.

@danhoeflinger danhoeflinger added this to the 2022.8.0 milestone Feb 1, 2025
@danhoeflinger danhoeflinger changed the title bugfix to avoid __out for MSVC Bugfix to avoid __out for MSVC Feb 1, 2025
Copy link
Contributor

@mmichel11 mmichel11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danhoeflinger danhoeflinger merged commit 60e06bd into main Feb 2, 2025
23 checks passed
@danhoeflinger danhoeflinger deleted the dev/dhoeflin/MSVC_out_bugfix branch February 2, 2025 01:32
Copy link
Contributor

@SergeyKopienko SergeyKopienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants