[oneDPL][rfc][ranges] proposal for implementation of the second part of range based API for oneDPL #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of range based API for oneDPL
akukanov
reviewed
Feb 3, 2025
rfcs/proposed/ranges_api_m/README.md
Outdated
There was a problem hiding this comment.
Please rename to range_algorithms/README.md
Co-authored-by: Alexey Kukanov <[email protected]>
akukanov
reviewed
Feb 12, 2025
Comment on lines
+13
to
+14
| - The range-based signatures for the mentioned API should correspond to the proposal for C++ parallel range algorithms, P3179. | ||
| (https://wg21.link/p3179) |
There was a problem hiding this comment.
As an exception to this rule, we might have mismatch to follow equal and transform in the oneDPL specification and allow only one of the two ranges to be sized.
I am still thinking of the best way to handle this.
| ### Key Requirements | ||
| - The range-based signatures for the mentioned API should correspond to the proposal for C++ parallel range algorithms, P3179. | ||
| (https://wg21.link/p3179) | ||
| - The proposed implementation should support all oneDPL execution policies: `seq`, `unseq`, `par`, `par_unseq` and `a device policy`. |
There was a problem hiding this comment.
Suggested change
| - The proposed implementation should support all oneDPL execution policies: `seq`, `unseq`, `par`, `par_unseq` and `a device policy`. | |
| - The proposed implementation should support all oneDPL execution policies: `seq`, `unseq`, `par`, `par_unseq`, and `device_policy`. |
Comment on lines
+23
to
+25
| ### Test coverage | ||
|
|
||
| - It should be called with both small and large data sizes and with all the policies mentioned above. |
There was a problem hiding this comment.
Does it make sense to also mention what kinds of input and output ranges (containers, views, etc.) will be tested?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[oneDPL][rfc][ranges] proposal for implementation of the second part of range based API for oneDPL