Rework test accuracy for spsv

uxlfoundation · Sep 12, 2024 · 70cdbe0 · 70cdbe0
1 parent 7aa5177
commit 70cdbe0
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/tests/unit_tests/sparse_blas/include/test_common.hpp b/tests/unit_tests/sparse_blas/include/test_common.hpp
@@ -207,9 +207,9 @@ template <typename fpType>
 fpType generate_data(bool is_diag) {
     rand_scalar<fpType> rand_data;
     if (is_diag) {
-        // Guarantee an amplitude >= 0.1
+        // Guarantee a large amplitude
         fpType sign = (std::rand() % 2) * 2 - 1;
-        return rand_data(0.1, 0.5) * sign;
+        return rand_data(10, 20) * sign;
     }
     return rand_data(-0.5, 0.5);
 }

diff --git a/tests/unit_tests/sparse_blas/source/sparse_spsv_buffer.cpp b/tests/unit_tests/sparse_blas/source/sparse_spsv_buffer.cpp
@@ -47,6 +47,9 @@ int test_spsv(sycl::device *dev, sparse_matrix_format_t format, intType m, doubl
         matrix_properties.find(oneapi::mkl::sparse::matrix_property::symmetric) !=
         matrix_properties.cend();
 
+    // Use a fixed seed for operations very sensible to the input data
+    std::srand(1);
+
     // Input matrix
     std::vector<intType> ia_host, ja_host;
     std::vector<fpType> a_host;
@@ -171,10 +174,8 @@ int test_spsv(sycl::device *dev, sparse_matrix_format_t format, intType m, doubl
 
     // Compare the results of reference implementation and DPC++ implementation.
     // Increase default relative error margin for tests that lead to large numeric values.
-    double abs_error_factor = 10;
-    double rel_error_factor = 1E5;
     auto y_acc = y_buf.get_host_access(sycl::read_only);
-    bool valid = check_equal_vector(y_acc, y_ref_host, abs_error_factor, rel_error_factor);
+    bool valid = check_equal_vector(y_acc, y_ref_host);
 
     return static_cast<int>(valid);
 }

diff --git a/tests/unit_tests/sparse_blas/source/sparse_spsv_usm.cpp b/tests/unit_tests/sparse_blas/source/sparse_spsv_usm.cpp
@@ -43,6 +43,9 @@ int test_spsv(sycl::device *dev, sparse_matrix_format_t format, intType m, doubl
         matrix_properties.find(oneapi::mkl::sparse::matrix_property::symmetric) !=
         matrix_properties.cend();
 
+    // Use a fixed seed for operations very sensible to the input data
+    std::srand(1);
+
     // Input matrix
     std::vector<intType> ia_host, ja_host;
     std::vector<fpType> a_host;
@@ -219,10 +222,8 @@ int test_spsv(sycl::device *dev, sparse_matrix_format_t format, intType m, doubl
 
     // Compare the results of reference implementation and DPC++ implementation.
     // Increase default relative error margin for tests that lead to large numeric values.
-    double abs_error_factor = 10;
-    double rel_error_factor = 1E5;
     ev_copy.wait_and_throw();
-    bool valid = check_equal_vector(y_host, y_ref_host, abs_error_factor, rel_error_factor);
+    bool valid = check_equal_vector(y_host, y_ref_host);
 
     return static_cast<int>(valid);
 }