Skip to content

Commit

Permalink
Avoid capture by reference
Browse files Browse the repository at this point in the history
  • Loading branch information
Rbiessy committed Dec 2, 2024
1 parent b6518c9 commit c53ef8d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -304,11 +304,11 @@ sycl::event spmm(sycl::queue& queue, oneapi::mkl::transpose opA, oneapi::mkl::tr
detail::check_valid_spmm(__func__, A_view, A_handle, B_handle, C_handle,
is_alpha_host_accessible, is_beta_host_accessible);
A_handle->mark_used();
auto& buffer_size = spmm_descr->temp_buffer_size;
bool is_in_order_queue = queue.is_in_order();
auto compute_functor = [=, &buffer_size](void* workspace_ptr) {
auto compute_functor = [=](void* workspace_ptr) {
auto roc_handle = spmm_descr->roc_handle;
auto hip_stream = spmm_descr->hip_stream;
auto buffer_size = spmm_descr->temp_buffer_size;
auto roc_a = A_handle->backend_handle;
auto roc_b = B_handle->backend_handle;
auto roc_c = C_handle->backend_handle;
Expand All @@ -324,7 +324,7 @@ sycl::event spmm(sycl::queue& queue, oneapi::mkl::transpose opA, oneapi::mkl::tr
detail::synchronize_if_needed(is_in_order_queue, hip_stream);
};
// The accessor can only be created if the buffer size is greater than 0
if (A_handle->all_use_buffer() && buffer_size > 0) {
if (A_handle->all_use_buffer() && spmm_descr->temp_buffer_size > 0) {
auto functor_buffer = [=](sycl::interop_handle ih,
sycl::accessor<std::uint8_t> workspace_acc) {
auto workspace_ptr = detail::get_mem(ih, workspace_acc);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -305,11 +305,11 @@ sycl::event spmv(sycl::queue& queue, oneapi::mkl::transpose opA, const void* alp
CHECK_DESCR_MATCH(spmv_descr, alg, "spmv_optimize");

A_handle->mark_used();
auto& buffer_size = spmv_descr->temp_buffer_size;
bool is_in_order_queue = queue.is_in_order();
auto compute_functor = [=, &buffer_size](void* workspace_ptr) {
auto compute_functor = [=](void* workspace_ptr) {
auto roc_handle = spmv_descr->roc_handle;
auto hip_stream = spmv_descr->hip_stream;
auto buffer_size = spmv_descr->temp_buffer_size;
auto roc_a = A_handle->backend_handle;
auto roc_x = x_handle->backend_handle;
auto roc_y = y_handle->backend_handle;
Expand All @@ -324,7 +324,7 @@ sycl::event spmv(sycl::queue& queue, oneapi::mkl::transpose opA, const void* alp
detail::synchronize_if_needed(is_in_order_queue, hip_stream);
};
// The accessor can only be created if the buffer size is greater than 0
if (A_handle->all_use_buffer() && buffer_size > 0) {
if (A_handle->all_use_buffer() && spmv_descr->temp_buffer_size > 0) {
auto functor_buffer = [=](sycl::interop_handle ih,
sycl::accessor<std::uint8_t> workspace_acc) {
auto workspace_ptr = detail::get_mem(ih, workspace_acc);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -285,11 +285,11 @@ sycl::event spsv(sycl::queue& queue, oneapi::mkl::transpose opA, const void* alp
CHECK_DESCR_MATCH(spsv_descr, alg, "spsv_optimize");

A_handle->mark_used();
auto& buffer_size = spsv_descr->temp_buffer_size;
bool is_in_order_queue = queue.is_in_order();
auto compute_functor = [=, &buffer_size](void* workspace_ptr) {
auto compute_functor = [=](void* workspace_ptr) {
auto roc_handle = spsv_descr->roc_handle;
auto hip_stream = spsv_descr->hip_stream;
auto buffer_size = spsv_descr->temp_buffer_size;
auto roc_a = A_handle->backend_handle;
auto roc_x = x_handle->backend_handle;
auto roc_y = y_handle->backend_handle;
Expand All @@ -305,7 +305,7 @@ sycl::event spsv(sycl::queue& queue, oneapi::mkl::transpose opA, const void* alp
detail::synchronize_if_needed(is_in_order_queue, hip_stream);
};
// The accessor can only be created if the buffer size is greater than 0
if (A_handle->all_use_buffer() && buffer_size > 0) {
if (A_handle->all_use_buffer() && spsv_descr->temp_buffer_size > 0) {
auto functor_buffer = [=](sycl::interop_handle ih,
sycl::accessor<std::uint8_t> workspace_acc) {
auto workspace_ptr = detail::get_mem(ih, workspace_acc);
Expand Down

0 comments on commit c53ef8d

Please sign in to comment.