[DFT] Implement external workspace according to draft spec #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rbiessy
reviewed
Nov 20, 2023
FMarno
reviewed
Nov 20, 2023
FMarno
reviewed
Nov 20, 2023
t4c1
reviewed
Nov 21, 2023
Rbiessy
approved these changes
Nov 27, 2023
FMarno
reviewed
Nov 27, 2023
FMarno
approved these changes
Nov 28, 2023
t4c1
approved these changes
Nov 29, 2023
hjabird
force-pushed
the
devel_dft_workspace_external
branch
from
aa0967a to
718ecf0
Compare
|
I've been having trouble with access to AMD hardware since the rebase, so test here is test data for MKL-CPU, MKL-GPU and Nvidia for now: |
* Implementation for supporting external workspaces according to draft specification * Supporting MKL-GPU, rocFFT, cuFFT. * MKL-CPU needs minor changes, but does not support external workspaces * Initial tests
hjabird
force-pushed
the
devel_dft_workspace_external
branch
from
718ecf0 to
2a4bb85
Compare
|
This PR has been rebased:
Test results for Nvidia (cuFFT backend), Intel MKL-CPU and MKL-GPU, and portFFT on Intel are attached: Unfortunately I cannot currently access AMD hardware to test that the rocFFT backend. However, it has not required any changes since the last test results were provided. |
Rbiessy
reviewed
Dec 18, 2023
Rbiessy
approved these changes
Dec 19, 2023
normallytangent
pushed a commit
to normallytangent/oneMKL
that referenced
this pull request
Aug 6, 2024
* Implements external workspace support in DFT domain, with support for all existing backends. * Adds new tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the draft specification for external workspace at uxlfoundation/oneAPI-spec#509, which relates to oneMKL issue #396.
Checklist
All Submissions
New interfaces
it was accepted? # (RFC) Draft PR for oneAPI spec linked, but this is not yet merged
New features
Logs: