-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LAPACK] Add Arm Performance Libraries backend #633
[LAPACK] Add Arm Performance Libraries backend #633
Conversation
Signed-off-by: Augustin Degomme <[email protected]> Co-authored-by: Nicolas Bouton <[email protected]> Co-authored-by: Romain Dolbeau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No concern from my side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this awesome contribution! A few questions/comments from my side
include/oneapi/math/lapack/detail/armpl/onemath_lapack_armpl.hpp
Outdated
Show resolved
Hide resolved
/intelci: run |
…triggered in Fortran lapack layer and just halt execution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your work here! I just had one last question, but I don't think the extra code is harming anything.
We don't currently have any aarch64 systems to validate on, so thank you for validating on your side. Thanks again!
Description
This adds the Lapack backend for ArmPl on aarch64 CPUs.
Batch versions are not yet implemented.
Due to the LAPACKE interface used in ArmPl not exactly matching oneMath, some _scratchpad sizes are not queried and allocated/deallocated on the go (heevg, hegvd, .. which would need multiple work arrays with different sizes)
Checklist
All Submissions
log_lapack.txt
100% of the tests are reported as passing, which is an issue actually on the lapack backend (no skipped state, fix coming in another MR)