Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent_bounding_queue capacity on copy, move and swap operations #1609

Merged
merged 6 commits into from
Jan 21, 2025

Conversation

kboyarinov
Copy link
Contributor

@kboyarinov kboyarinov commented Jan 20, 2025

Description

concurrent_bounded_queue capacity was not preserved while copy/move construction and assignment and on swap.
The target queue always used its previous capacity, or an unbounded capacity.

Fixes #1598

Type of change

Choose one or multiple, leave empty if none of the other choices apply

Add a respective label(s) to PR if you have permissions

  • bug fix - change that fixes an issue
  • new feature - change that adds functionality
  • tests - change in tests
  • infrastructure - change in infrastructure and CI
  • documentation - documentation update

Tests

  • added - required for new features and some bug fixes
  • not needed

Documentation

  • updated in # - add PR number
  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

Notify the following users

List users with @ to send notifications

Other information

@phprus
Copy link
Contributor

phprus commented Jan 21, 2025

test_buffer_node timeout issue: #1467 (Aug 4, 2024)

Copy link
Contributor

@aleksei-fedotov aleksei-fedotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kboyarinov kboyarinov merged commit 0d73df4 into master Jan 21, 2025
25 checks passed
@kboyarinov kboyarinov deleted the dev/kboyarinov/cbq_capacity_fix branch January 21, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A copy of a concurrent bounded queue doesn't preserve the capacity of the original queue object.
4 participants