Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-format: fix output. #566

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

hvdijk
Copy link
Collaborator

@hvdijk hvdijk commented Oct 15, 2024

Overview

clang-format: fix output.

Reason for change

Now that we have upgraded to clang-format-19, its exit status already indicates whether any changes were suggested. We no longer need to save it to a file and count the lines, and our efforts were causing the output to be hidden.

Description of change

Describe the intended behaviour your changes are meant to introduce to the
project and explain how they resolve the problem stated above. Detail any
relevant changes that may affect other users of the project, such as
compilation options, runtime flags, expected inputs and outputs, API entry
points, etc.

If you have added new testing, provide details on what tests you have added
and what the purpose of them is.

Anything else we should know?

If there's any other relevant information we should know that may help us in
understanding and verifying your patch, please include it here.

Checklist

  • Read and follow the project Code of Conduct.
  • Make sure the project builds successfully with your changes.
  • Run relevant testing locally to avoid regressions.
  • Run clang-format-19 on all modified code.

@hvdijk hvdijk requested a review from a team as a code owner October 15, 2024 14:11
Now that we have upgraded to clang-format-19, its exit status already
indicates whether any changes were suggested. We no longer need to save
it to a file and count the lines, and our efforts were causing the
output to be hidden.
@hvdijk hvdijk merged commit d983db7 into uxlfoundation:main Oct 15, 2024
6 checks passed
@hvdijk hvdijk deleted the fix-clang-format branch October 15, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants