-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KMeans OOP #1770
KMeans OOP #1770
Conversation
/intelci: run |
I know its a draft, but this is a note for my future review: please enable all k_means GPU tests (i.e. remove from deselected_tests) and see what passes. This will be necessary to pull this code out of preview. |
/intelci: run |
/azp run CI |
Azure Pipelines successfully started running 1 pipeline(s). |
/intelci: run |
/azp run CI |
Azure Pipelines successfully started running 1 pipeline(s). |
/intelci: run |
/intelci: run |
/intelci: run |
/intelci: run |
/intelci: run |
The private CI warnings are not related. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on tests!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this. CI is in good shape and test coverage is nice. Pending resolution of any unresolved comments and manager approval.
This reverts commit fede266.
This PR intends to take KMeans algorithm out of preview namespace. The changes proposed:
Nuances: KMeans Init does not have GPU support for sparse data. Hence CPU implementation is used using Host policy.
Based on #1634.
Needs to merge uxlfoundation/oneDAL#2815 first.
Fixes # - issue number(s) if exists