-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: fixing spmd tests utilities for dpctl inputs #1999
FIX: fixing spmd tests utilities for dpctl inputs #1999
Conversation
/intelci: run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change in naming convention to keep it compact. Otherwise good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please make sure the naming dispute is settled
/intelci: run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve. Just for posterity, and alternate solution as we have talked about elsewhere would have been to use get_namespace. This may be a better convention going forward than using parametrized numpy dtypes, assert(data.dtype == getattr(get_namespace(data)[0], dtype.__name__))
I think this less common for our primitives, so better to convert to one dataframe format then compare. |
@mergify backport rls/2024.7.0-rls |
✅ Backports have been created
|
* FIX: fixing spmd tests utilities for dpctl inputs (cherry picked from commit 18d0428)
* FIX: fixing spmd tests utilities for dpctl inputs (cherry picked from commit 18d0428) Co-authored-by: Samir Nasibli <[email protected]>
Description
DPCTL doesn't support some numpy-like ufunc functionality, For example, loop of ufunc does not support argument 0 of type dpctl.tensor._usmarray.usm_ndarray which has no callable conjugate method.
Make sense before some manipulations with resulted dpctl or any other non-numpy arrays convert to numpy before and do comparison with expected numpy arrays.
Found on #1861
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance