Sklearn 1.6 support #2221
Merged
Sklearn 1.6 support #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/intelci: run |
4 similar comments
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
|
/intelci: run |
Alexsandruss
added
sklearn-patch
|
/intelci: run |
Alexsandruss
requested review from
samir-nasibli,
icfaust,
ethanglaser,
napetrov,
homksei and
ahuber21
as code owners
icfaust
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Overall pretty good. @Alexsandruss are we going to do anything to control the sklearn version in conda-recipe to prevent CI failures, or was that bug a feature?
|
/intelci: run |
icfaust
approved these changes
Dec 12, 2024
|
Merge on green CI, we will need to also make tickets to upgrade private CI and update the public README.md about support. |
Alexsandruss
force-pushed
the
dev/sklearn-1.6-support
branch
from
04a9981 to
12874f6
Compare
Alexsandruss
requested review from
maria-Petrova and
david-cortes-intel
as code owners
ethanglaser
reviewed
Dec 12, 2024
ethanglaser
reviewed
Dec 12, 2024
ethanglaser
reviewed
Dec 12, 2024
|
/intelci: run |
|
I guess this should also be updated: https://github.com/uxlfoundation/scikit-learn-intelex/blob/main/doc/sources/quick-start.rst?plain=1#L377-L382 |
ethanglaser
approved these changes
Dec 12, 2024
I have added a ticket for private CI |
1 task
Separate PR with update of supported versions and others docs would be better. |
david-cortes-intel
pushed a commit
to david-cortes-intel/scikit-learn-intelex
that referenced
this pull request
Jan 8, 2025
* Apply scipy array API support * Deselect tests for unsupported skl1.6 features * Add sklearn 1.6 to CI matrix * Fix pairwise_distances dispatching * Fix forbidden usage of sklearn_check_version * Fix for pairwise_distances params validation * Fix for pairwise_distances params validation * Fix for pairwise_distances params validation * Add SCIPY_ARRAY_API to test_estimators * Update input validation in AdaBoost and GBT d4p estimators * Pin sklearn 1.5 for py3.9 * Fix knn bf regr spmd example * Update python-sklearn CI matrix * Apply comments for AdaBoost and GBT estimators * Add sklearn 1.6 to README badge * Linting * Update metric in knn bf regr spmd example * Update CI matrix
david-cortes-intel
pushed a commit
to david-cortes-intel/scikit-learn-intelex
that referenced
this pull request
Jan 8, 2025
* Apply scipy array API support * Deselect tests for unsupported skl1.6 features * Add sklearn 1.6 to CI matrix * Fix pairwise_distances dispatching * Fix forbidden usage of sklearn_check_version * Fix for pairwise_distances params validation * Fix for pairwise_distances params validation * Fix for pairwise_distances params validation * Add SCIPY_ARRAY_API to test_estimators * Update input validation in AdaBoost and GBT d4p estimators * Pin sklearn 1.5 for py3.9 * Fix knn bf regr spmd example * Update python-sklearn CI matrix * Apply comments for AdaBoost and GBT estimators * Add sklearn 1.6 to README badge * Linting * Update metric in knn bf regr spmd example * Update CI matrix
5 tasks
napetrov
pushed a commit
that referenced
this pull request
Jan 8, 2025
* Apply scipy array API support * Deselect tests for unsupported skl1.6 features * Add sklearn 1.6 to CI matrix * Fix pairwise_distances dispatching * Fix forbidden usage of sklearn_check_version * Fix for pairwise_distances params validation * Fix for pairwise_distances params validation * Fix for pairwise_distances params validation * Add SCIPY_ARRAY_API to test_estimators * Update input validation in AdaBoost and GBT d4p estimators * Pin sklearn 1.5 for py3.9 * Fix knn bf regr spmd example * Update python-sklearn CI matrix * Apply comments for AdaBoost and GBT estimators * Add sklearn 1.6 to README badge * Linting * Update metric in knn bf regr spmd example * Update CI matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
SCIPY_ARRAY_APIto1which is required for sklearn>=1.6 ifarray-api-compatis installed in:pairwise_distancesPR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance
N/A