[Release] v1.0.0b29 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update .swiftlint.yml * Add tabbar assets * Add darkmode support * Add UI flow oriented project structure
* Add TabBar animations for LongPress and Tap * Add support for TabBar panning / multiple fingers via TabBarPressGestureRecognizer * Update project structure (common folder) * Add swiftlint cyclomatic_complexity settings
* Add NavigationCoordinator, ChildCoordinator * Add DiscoverNavigationCoordinator * Add Reselectable and update reselect in TabBarCoordinator
* Update TabBarCoordinator with MyTeamsNavigationCoordinator for the proper tab * Update MyTeamsCoordinator to proper viewController
Update appropriate viewcontrollers and coordinators that didn't use this navigationcontrolle previously.
* Add DiscoverVC segmented control, DiscoverSection and viewModel * Add SearchCoordinator and viewController * Add ActionButton * Add CustomTextField
* SectioningCoordinators now require ChildViewControllerContainerProviding viewcontrollers * Change TabBarCoordinator and DiscoverCoordinator to Sectioning * Add TappableLabel and add it to TeamListVC * Add League, TeamPreview models
* Add TeamListTableViewCell base that display just the image and name of a team * No gesture interaction yet, no networking
* GET /leagues
* GET /leagues/{leagueID}
* Remove APIManager request body code
* Add SDWebImage pod, update Podfile, Podfile.lock * Add image downloading in TeamListTableViewCell via SDWebImage * Add iOS 12 support for BarButtonItems, NavigationBar and UILabel * Add UILabel.Style enum for custom styling * Fix NavigationBar behavior, especially in DiscoverViewController which now ignores the navigationBar completely. The VC inserts subviews below the navigationBar and fakes the prefersLargeTitles navBar look. * Add BetterpickAPIManagerMock + mocks for Bundesliga * Add RootViewController to fix dark bar appearing while pop/pushing a new VC on the navigation stack * Add UIPickerView to TeamListViewController's competition label. Add TappableResponderLabel. * Add UIView extensions for embedding views * Add PlayerSelecting and TeamSelecting protocols for easier coordinator interaction. * Add EmptyStatePresenting protocol and FetchingView for handling empty states and fetching (via UIActivityIndicator) * Add xcconfigs for Debug, Mock and Release
* TeamListVC extensions were moved into multiple files to reduce LoC in a single file * Update Reselectable to account for children ViewControllers that are also reselectable * Add TeamListSeparatorAnimator that shows/hides the separator in TeamListVC. (separator between the tableView and the competitionInfoLabel)
* Add Team model and update PlayerPreview * Update APIManager with new endpoint request
* TeamViewController now populates the entire tableview with players
* PlayerDetail fetches /players/{playerID}
* Add SearchViewModel, Add SearchViewController and SearchSectionResult, SearchResult models * Updaet TeamSelecting & PlayerSelecting coordinators accordingly * Update Player model * Change CustomTextField keyboardReturnType
* Add KeyPaths to SearchResult and remove Section enum
* Refactor the code from SearchVC to multiple files
* Add /search and /players/{playerID} to APIMock
* Rename variables, classes etc * Fix TeamListSeparatorAnimator
* Add title property to ViewModel * Use NavigationBarDisplaying protocol methods in VC
* Add FetchingViewModel to share the functionality between other viewmodels that fetch some resources * Refactor TeamViewModel to FetchingViewModel * Add SimpleFetchingViewModel and refactor PlayerDetailViewModel to SimpleFetchingVM * Create file for capitalize String extension
* Add LeagueAndNationalityData model to be fetched in the AppCoordinator. If the fetching fails, the tabBarCoordinator is not started. * Add VMViewController base class for VCs with a VM
* Add filter_slider asset
* Add PlayerFilterData model that represents the data the user selected while searching * Add PlayerFilter VM and VC * Update DiscoverPlayer with a filtering label and startFiltering ActionButton
* Update README * Fix Fastfile git branch while running on Travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated PR via Fastlane. 🚀