feat: Add daily active users license model documentation #3658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: document DAUCustomizer interface * Apply suggestions from code review Co-authored-by: Tomi Virtanen <[email protected]> * vale fixes * vale fixes --------- Co-authored-by: Tomi Virtanen <[email protected]>
* feat: Add DAU general description * add a note about sub key and app name prefix * fix lint issues * fix review comments
github-actions
bot
added
the
Language unchecked
|
I think we should update this phrase in the Licenses page
With DAU introduction, also Premium requires the license for production use. |
Changed. |
mcollovati
reviewed
Sep 13, 2024
Co-authored-by: Marco Collovati <[email protected]>
mcollovati
approved these changes
Sep 13, 2024
Legioth
reviewed
Sep 16, 2024
Legioth
reviewed
Sep 16, 2024
# Conflicts: # .github/styles/Vaadin/Abbr.yml
Legioth
approved these changes
Sep 20, 2024
paulroemer
reviewed
Sep 23, 2024
mcollovati
reviewed
Sep 24, 2024
mcollovati
requested changes
Sep 26, 2024
mcollovati
approved these changes
Sep 26, 2024
paulroemer
reviewed
Sep 27, 2024
There was a problem hiding this comment.
Unfortunately, outdated. Maybe we can update it once more when the stuff is released on (likely) Monday.
There was a problem hiding this comment.
Yes, let's update it next week.
russelljtdyer
added
Language checking
russelljtdyer
added
Language checked
cromoteca
pushed a commit
that referenced
this pull request
Sep 30, 2024
* feat: add DAU documentation * feat: document DAUCustomizer interface (#3648) * feat: document DAUCustomizer interface * Apply suggestions from code review Co-authored-by: Tomi Virtanen <[email protected]> * vale fixes * vale fixes --------- Co-authored-by: Tomi Virtanen <[email protected]> * feat: Add DAU general description (#3653) * feat: Add DAU general description * add a note about sub key and app name prefix * fix lint issues * fix review comments * add since label * correct the runtime licenses note * Update articles/flow/configuration/licenses/index.adoc Co-authored-by: Marco Collovati <[email protected]> * fix review comments * fix lint comments * add a better explanation for active users * add a note about sub key in runtime * added a note about dev mode * add license-checker * runtime only * Initial pass at editing. * Second pass at editing: index.adoc * Second pass at editing: daily-active-users.adoc * Vale fixes. * Third pass at editing documents * Vale fixes. --------- Co-authored-by: Marco Collovati <[email protected]> Co-authored-by: Tomi Virtanen <[email protected]> Co-authored-by: Russell J.T. Dyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.