Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gradle): replace outdated properties from hilla to vaadin #3716

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

DuncanCasteleyn
Copy link
Contributor

The currently documented properties are outdated and no longer work

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2024

CLA assistant check
All committers have signed the CLA.

@DuncanCasteleyn DuncanCasteleyn changed the title fix(gradle): relace oudate properties from hilla to vaadin fix(gradle): replace outdated properties from hilla to vaadin Sep 24, 2024
Copy link
Contributor

@taefi taefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole document needs to be update with vaadin namespace instead of hilla, but this change on its own LGTM, and can be merged.
Thanks for the contribution!

@taefi taefi merged commit 0073092 into vaadin:latest Sep 25, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants