-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: sort imports in React examples #3719
Conversation
bc31d5d
to
2f4578b
Compare
2f4578b
to
b2e8bcc
Compare
Lint failed because the diff exceeded the maximum number of files it can process at once (300). |
"^Frontend/demo/react-example", | ||
"^react", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this group to soften the impact. We could consider moving lit dependencies also to the top.
import { Avatar } from '@vaadin/react-components'; | ||
import { HorizontalLayout } from '@vaadin/react-components/HorizontalLayout'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could combine with the above import of Avatar
to import both from @vaadin/react-components
.
This file was updated in #3538 but apparently this import wasn't covered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll create a separate PR for that.
frontend/demo/component/datepicker/react/date-picker-basic-features.tsx
Outdated
Show resolved
Hide resolved
import { TextArea, type TextAreaChangeEvent } from '@vaadin/react-components/TextArea.js'; | ||
import type { | ||
RichTextEditorElement, | ||
RichTextEditorValueChangedEvent, | ||
} from '@vaadin/react-components-pro/RichTextEditor.js'; | ||
import { RichTextEditor } from '@vaadin/react-components-pro/RichTextEditor.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could combine with import type
above into single import.
import type { TimePickerChangeEvent } from '@vaadin/react-components/TimePicker.js'; | ||
import { TimePicker } from '@vaadin/react-components/TimePicker.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could combine this with import type
above.
import type { UploadFileRejectEvent } from '@vaadin/react-components/Upload.js'; | ||
import { Upload } from '@vaadin/react-components/Upload.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could combine this with import type
above.
…tures.tsx Co-authored-by: Serhii Kulykov <[email protected]>
Co-authored-by: Serhii Kulykov <[email protected]>
No description provided.