Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sort imports in React examples #3719

Merged
merged 6 commits into from
Sep 26, 2024
Merged

refactor: sort imports in React examples #3719

merged 6 commits into from
Sep 26, 2024

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Sep 25, 2024

No description provided.

@vursen vursen force-pushed the sort-imports-6 branch 2 times, most recently from bc31d5d to 2f4578b Compare September 25, 2024 12:48
@vursen vursen changed the title refactor: sort imports in React examples (1) refactor: sort imports in React examples Sep 25, 2024
@vursen vursen marked this pull request as ready for review September 25, 2024 12:56
@vursen
Copy link
Contributor Author

vursen commented Sep 25, 2024

Lint failed because the diff exceeded the maximum number of files it can process at once (300).

Comment on lines +49 to +50
"^Frontend/demo/react-example",
"^react",
Copy link
Contributor Author

@vursen vursen Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this group to soften the impact. We could consider moving lit dependencies also to the top.

import { Avatar } from '@vaadin/react-components';
import { HorizontalLayout } from '@vaadin/react-components/HorizontalLayout';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could combine with the above import of Avatar to import both from @vaadin/react-components.
This file was updated in #3538 but apparently this import wasn't covered.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll create a separate PR for that.

import { TextArea, type TextAreaChangeEvent } from '@vaadin/react-components/TextArea.js';
import type {
RichTextEditorElement,
RichTextEditorValueChangedEvent,
} from '@vaadin/react-components-pro/RichTextEditor.js';
import { RichTextEditor } from '@vaadin/react-components-pro/RichTextEditor.js';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could combine with import type above into single import.

frontend/demo/component/side-nav/react/side-nav-basic.tsx Outdated Show resolved Hide resolved
import type { TimePickerChangeEvent } from '@vaadin/react-components/TimePicker.js';
import { TimePicker } from '@vaadin/react-components/TimePicker.js';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could combine this with import type above.

import type { UploadFileRejectEvent } from '@vaadin/react-components/Upload.js';
import { Upload } from '@vaadin/react-components/Upload.js';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could combine this with import type above.

@vursen vursen enabled auto-merge (squash) September 26, 2024 10:26
@vursen vursen merged commit ee47c19 into latest Sep 26, 2024
2 of 4 checks passed
@vursen vursen deleted the sort-imports-6 branch September 26, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants