Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: align spring boot version with 24.5 #3814

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from

Conversation

knoobie
Copy link
Contributor

@knoobie knoobie commented Oct 16, 2024

Not sure how you handle different minor versions in the docs, that part is up to you :) This PR is here to create a "discussion"

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2024

CLA assistant check
All committers have signed the CLA.

@mshabarov mshabarov self-requested a review October 28, 2024 12:57
@mshabarov
Copy link
Contributor

mshabarov commented Oct 28, 2024

It's not only Spring Boot version that isn't the latest.
This table gives "minimum required" versions, whereas release notes usually give "supported" versions.
I was going to suggest adding a link to Vaadin Platform release notes, but turned out that it's already in place right in the beginning, see https://vaadin.com/docs/latest/compatibility.

Instead of changing versions in the table, I'd suggest rephrasing this sentence

See the [release notes](https://github.com/vaadin/platform/releases/tag/24.0.0) for more details.

to something like:

Minimum supported versions may vary between Vaadin 24 minor releases. For details on specific minor versions, please refer to the [release notes](https://github.com/vaadin/platform/releases/latest | https://github.com/vaadin/platform/releases).

@mshabarov mshabarov requested review from manolo and removed request for mshabarov October 28, 2024 13:54
@jouni
Copy link
Member

jouni commented Nov 19, 2024

Previous minors are only supported for 3 months after the next minor has been released, right? The latest documentation covers the latest supported versions, not all minors for the current major version (V24 today). So if 24.4 and 24.5 require Spring Boot 3.3, then that’s what we should indicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants