feat: grid empty state content #6321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
force-pushed
the
feat/grid/empty-state
branch
from
0f3fca3
to
998c70e
Compare
tomivirkki
force-pushed
the
feat/grid/empty-state
branch
from
998c70e
to
d6e8611
Compare
Comment on lines
5065
to
5087
| /** | ||
| * Sets the component to be displayed when the grid is empty. | ||
| * | ||
| * @param emptyStateComponent | ||
| * the component to be displayed when the grid is empty | ||
| */ | ||
| public void setEmptyStateComponent(Component emptyStateComponent) { | ||
| this.emptyStateText = null; | ||
| this.emptyStateComponent = emptyStateComponent; | ||
| updateEmptyStateContent(); | ||
| } | ||
|
|
||
| /** | ||
| * Sets the text to be displayed when the grid is empty. | ||
| * | ||
| * @param emptyStateText | ||
| * the text to be displayed when the grid is empty | ||
| */ | ||
| public void setEmptyStateText(String emptyStateText) { | ||
| this.emptyStateComponent = null; | ||
| this.emptyStateText = emptyStateText; | ||
| updateEmptyStateContent(); | ||
| } |
There was a problem hiding this comment.
Should the Javadoc mention that calling one setter will remove whatever has been defined by the other setter? I think that, generally, a setter is understood as an overriding task, but since in this case, we have two different setters around the same feature, we could make it clearer.
There was a problem hiding this comment.
Makes sense, updated the documentation
|
DiegoCardoso
approved these changes
May 29, 2024
vursen
reviewed
May 29, 2024
vaadin-grid-flow-parent/vaadin-grid-flow/src/main/java/com/vaadin/flow/component/grid/Grid.java
Show resolved
Hide resolved
vursen
approved these changes
May 29, 2024
|
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on vaadin/web-components#7429
Add empty state API to
Grid:setEmptyStateComponentsetEmptyStateTextgetEmptyStateComponentgetEmptyStateTextSetting empty state content to the
Gridmakes it display the content whenever there are no items to render.Part of vaadin/platform#5719
Type of change
Feature