feat: add i18n error message support for DatePicker #6360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vursen
force-pushed
the
feat/date-picker/error-messages
branch
from
02d4762
to
d53bd01
Compare
...t/vaadin-date-picker-flow/src/main/java/com/vaadin/flow/component/datepicker/DatePicker.java
Outdated
Show resolved
Hide resolved
vursen
force-pushed
the
feat/date-picker/error-messages
branch
from
9a54a4b
to
f9396d6
Compare
|
During our internal discussion, we discovered a way to keep error messages that are set with |
vursen
requested review from
DiegoCardoso and
sissbruecker
and removed request for
sissbruecker
vursen
changed the title
DiegoCardoso
approved these changes
Jul 19, 2024
sissbruecker
approved these changes
Jul 23, 2024
|
|
This ticket/PR has been released with Vaadin 24.5.0.alpha6 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR enhances DatePickerI18n with methods for setting error messages and updates the DatePicker's validation logic to show these error messages when validation fails.
Note
It's still possible to use the
setErrorMessagemethod to configure a single static error message. This error message will be displayed for all constraints and will take priority over any i18n error messages that are also set. However, when more than one error message is needed, i18n should be used or manual validation mode should be enabled.Part of #4618
Type of change