Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add i18n error message support for Select #6468

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Jul 23, 2024

Description

The PR introduces SelectI18n with a method for setting a required error message and updates the Select's validation logic to show this error message when validation fails.

Part of #4618

Type of change

  • Feature

@vursen vursen marked this pull request as ready for review July 24, 2024 08:15
@vursen vursen enabled auto-merge (squash) July 30, 2024 06:20
Copy link

sonarcloud bot commented Jul 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
13.9% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

@vursen vursen merged commit c8d1afe into main Jul 30, 2024
4 of 5 checks passed
@vursen vursen deleted the feat/select/error-messages branch July 30, 2024 06:31
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha6 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants