feat: support drag drop for dashboard #6633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ugur-vaadin
force-pushed
the
feat/dashboard-drag-drop
branch
from
cc333af
to
d1d2d89
Compare
ugur-vaadin
commented
Sep 10, 2024
| return true; | ||
| } | ||
|
|
||
| private void customizeItemReorderEndEvent() { |
There was a problem hiding this comment.
I added this back because I encountered the same problem even after using just the Object to work around the serialization issue.
tomivirkki
reviewed
Sep 11, 2024
...arent/vaadin-dashboard-flow/src/main/java/com/vaadin/flow/component/dashboard/Dashboard.java
Show resolved
Hide resolved
tomivirkki
reviewed
Sep 11, 2024
...arent/vaadin-dashboard-flow/src/main/java/com/vaadin/flow/component/dashboard/Dashboard.java
Outdated
Show resolved
Hide resolved
tomivirkki
reviewed
Sep 12, 2024
...arent/vaadin-dashboard-flow/src/main/java/com/vaadin/flow/component/dashboard/Dashboard.java
Outdated
Show resolved
Hide resolved
...ation-tests/src/test/java/com/vaadin/flow/component/dashboard/tests/DashboardDragDropIT.java
Outdated
Show resolved
Hide resolved
|
tomivirkki
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds drag drop support for dashboard.
Added API:
void setEditable(boolean editable): Sets the option to make the dashboard editableboolean isEditable(): Returns whether the dashboard is editableRegistration addItemReorderStartListener(ComponentEventListener listener): Adds an item reorder start listener to the dashboardRegistration addItemReorderEndListener(ComponentEventListener listener): Adds an item reorder end listener to the dashboardFixes https://github.com/orgs/vaadin/projects/70/views/1?pane=issue&itemId=78740411
Part of vaadin/platform#6626
Type of change
Feature