feat: enable components to notify binder when validation state changes #13940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the number of tests grows the timeout also should be increased.
mshabarov
requested changes
Jun 15, 2022
flow-data/src/main/java/com/vaadin/flow/data/binder/ValidationStatusChangeEvent.java
Show resolved
Hide resolved
flow-data/src/main/java/com/vaadin/flow/data/binder/ValidationStatusChangeListener.java
Show resolved
Hide resolved
14 tasks
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
flow-data/src/main/java/com/vaadin/flow/data/binder/HasValidator.java
Outdated
Show resolved
Hide resolved
flow-data/src/main/java/com/vaadin/flow/data/binder/HasValidator.java
Outdated
Show resolved
Hide resolved
mshabarov
reviewed
Jun 16, 2022
flow-data/src/main/java/com/vaadin/flow/data/binder/HasValidator.java
Outdated
Show resolved
Hide resolved
vaadin-bot
pushed a commit
that referenced
this pull request
Jun 16, 2022
#13940) * feat: enable components to notify binder about their validation status changes Co-authored-by: Mikhail Shabarov <[email protected]>
vaadin-bot
pushed a commit
that referenced
this pull request
Jun 16, 2022
#13940) * feat: enable components to notify binder about their validation status changes Co-authored-by: Mikhail Shabarov <[email protected]>
vaadin-bot
pushed a commit
that referenced
this pull request
Jun 16, 2022
#13940) * feat: enable components to notify binder about their validation status changes Co-authored-by: Mikhail Shabarov <[email protected]>
vaadin-bot
pushed a commit
that referenced
this pull request
Jun 16, 2022
#13940) * feat: enable components to notify binder about their validation status changes Co-authored-by: Mikhail Shabarov <[email protected]>
mshabarov
added a commit
that referenced
this pull request
Jun 16, 2022
#13940) (#13994) * feat: enable components to notify binder about their validation status changes Co-authored-by: Mikhail Shabarov <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]> Co-authored-by: Mikhail Shabarov <[email protected]>
mshabarov
pushed a commit
that referenced
this pull request
Jun 17, 2022
#13940) (CP: 23.1) (#13993) Adds the needed API to notify Binder about validation status changes that happen in field components. Fixes #8242 Related to vaadin/flow-components#1158
taefi
pushed a commit
that referenced
this pull request
Jun 20, 2022
#13940) (CP: 9.0) (#13996) * feat: enable components to notify binder when validation state changes (#13940) Co-authored-by: Mikhail Shabarov <[email protected]>
taefi
pushed a commit
that referenced
this pull request
Jun 20, 2022
#13940) (CP: 2.8) (#13995) * feat: enable components to notify binder when validation state changes (#13940) Co-authored-by: Mikhail Shabarov <[email protected]>
taefi
pushed a commit
that referenced
this pull request
Jun 20, 2022
#13940) (CP: 2.7) (#13997) * feat: enable components to notify binder when validation state changes (#13940) Co-authored-by: Mikhail Shabarov <[email protected]>
9 tasks
|
@mshabarov I would like to work on a solution to deactivate this feature; I was wondering if you guys would prefer it on Binder-level or Binding-level. This could later be enhanced from |
9 tasks
taefi
pushed a commit
that referenced
this pull request
Jul 21, 2022
…on binder Add binder-level flag to allow disabling of validation status change listener registration for HasValidator fields. Related to #13940 (comment) and #13940 (comment)
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 21, 2022
…on binder Add binder-level flag to allow disabling of validation status change listener registration for HasValidator fields. Related to #13940 (comment) and #13940 (comment)
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 21, 2022
…on binder Add binder-level flag to allow disabling of validation status change listener registration for HasValidator fields. Related to #13940 (comment) and #13940 (comment)
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 21, 2022
…on binder Add binder-level flag to allow disabling of validation status change listener registration for HasValidator fields. Related to #13940 (comment) and #13940 (comment)
mcollovati
pushed a commit
that referenced
this pull request
Jul 21, 2022
…on binder (#14198) Add binder-level flag to allow disabling of validation status change listener registration for HasValidator fields. Related to #13940 (comment) and #13940 (comment) Co-authored-by: Knoobie <[email protected]>
mcollovati
pushed a commit
that referenced
this pull request
Jul 21, 2022
…on binder (#14197) Add binder-level flag to allow disabling of validation status change listener registration for HasValidator fields. Related to #13940 (comment) and #13940 (comment) Co-authored-by: Knoobie <[email protected]>
mcollovati
added a commit
that referenced
this pull request
Jul 21, 2022
…on binder (#14158) (CP: 9.0) (#14199) Add binder-level flag to allow disabling of validation status change listener registration for HasValidator fields. Related to #13940 (comment) and #13940 (comment) Co-authored-by: Knoobie <[email protected]> Co-authored-by: Marco Collovati <[email protected]>
taefi
pushed a commit
that referenced
this pull request
Jul 22, 2022
…on binder Add binder-level flag to allow disabling of validation status change listener registration for HasValidator fields. Related to #13940 (comment) and #13940 (comment) (cherry picked from commit 420498c)
taefi
added a commit
that referenced
this pull request
Jul 22, 2022
…on binder (#14205) Add binder-level flag to allow disabling of validation status change listener registration for HasValidator fields. Related to #13940 (comment) and vaadin/flow-components#3406 (comment) (cherry picked from commit 420498c) Co-authored-by: Knoobie <[email protected]>
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 22, 2022
…on binder (#14205) Add binder-level flag to allow disabling of validation status change listener registration for HasValidator fields. Related to #13940 (comment) and vaadin/flow-components#3406 (comment) (cherry picked from commit 420498c) Co-authored-by: Knoobie <[email protected]>
mcollovati
pushed a commit
that referenced
this pull request
Jul 25, 2022
…on binder (#14205) (#14208) Add binder-level flag to allow disabling of validation status change listener registration for HasValidator fields. Related to #13940 (comment) and vaadin/flow-components#3406 (comment) (cherry picked from commit 420498c) Co-authored-by: Knoobie <[email protected]> Co-authored-by: Soroosh Taefi <[email protected]>
|
This ticket/PR has been released with Vaadin 23.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the needed API to notify Binder about validation status changes that happen in field components.
Fixes #8242
Related to vaadin/flow-components#1158
Type of change
Checklist
Additional for
Featuretype of change