Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Test Vite 6 #19326

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -856,6 +856,7 @@ private List<String> getNpmExecutable(boolean removePnpmLock) {
returnCommand.add("--no-update-notifier");
returnCommand.add("--no-audit");
returnCommand.add("--scripts-prepend-node-path=true");
returnCommand.add("--legacy-peer-deps");

if (removePnpmLock) {
// remove pnpm-lock.yaml which contains pnpm as a dependency.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"license": "Apache-2.0",
"dependencies": {},
"devDependencies": {
"vite": "5.4.11",
"vite": "6.0.0-beta.10",
"@vitejs/plugin-react": "4.3.3",
"@preact/signals-react-transform": "0.4.0",
"@rollup/plugin-replace": "6.0.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ public void homeNodeIsNotForced_useGlobalNode()
not(containsString(vaadinHomeDir)));
assertThat(tools.getNodeExecutable(), not(containsString(baseDir)));

assertEquals(4, tools.getNpmExecutable().size());
assertEquals(5, tools.getNpmExecutable().size());
assertThat(tools.getNpmExecutable().get(0), containsString("npm"));
assertThat(tools.getNpmExecutable().get(1),
containsString("--no-update-notifier"));
Expand Down
Loading