Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Vaadin i18n plugin for translation analysis #19919

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

platosha
Copy link
Contributor

No description provided.

@platosha platosha added the hilla Issues related to Hilla label Sep 10, 2024
@vaadin-bot
Copy link
Collaborator

TC Format Checker Report - 07:33 - 10 - Sep

BLOCKER There are 1 files with format errors

  • To see a complete report of formatting issues, download the differences file

  • To fix the build, please run mvn formatter:format in your branch and commit the changes.

  • Optionally you might add the following line in your .git/hooks/pre-commit file:

    mvn formatter:format
    

Here is the list of files with format issues in your PR:

flow-server/src/test/java/com/vaadin/flow/server/frontend/TaskInstallFrontendBuildPluginsTest.java

Copy link

sonarcloud bot commented Sep 10, 2024

Copy link

Test Results

1 135 files  ± 0  1 135 suites  ±0   1h 29m 29s ⏱️ + 3m 27s
7 384 tests ± 0  7 334 ✅ ± 0  50 💤 ±0  0 ❌ ±0 
7 750 runs  +40  7 690 ✅ +40  60 💤 ±0  0 ❌ ±0 

Results for commit 34ce048. ± Comparison against base commit d5a4013.

@caalador
Copy link
Contributor

Seems fine, but needs running the formatter on the flow-server module.
Perhaps someone with better rollup knowledge could also have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hilla Issues related to Hilla +1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants