Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow running gradle plugin tests with JDK greater that 17 #20116

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

mcollovati
Copy link
Collaborator

Currently, running gradle plugin tests with a JDK greater than 17, and not having 17 installed on the system, fails because kotlin is configured to use a JDK 17 toolchain. This change replaces the toolchain setting for kotlin, pinning insted the jvmTarget compiler configuration to 17.

This is an alternative way to fix #17574.

Currently, running gradle plugin tests with a JDK greater
than 17, and not having 17 installed on the system, fails
because kotlin is configured to use a JDK 17 toolchain.
This change replaces the toolchain setting for kotlin,
pinning insted the jvmTarget compiler configuration to 17.

This is an alternative way to fix #17574.
Copy link

github-actions bot commented Oct 2, 2024

Test Results

1 139 files  ± 0  1 139 suites  ±0   1h 10m 33s ⏱️ +22s
7 410 tests ± 0  7 360 ✅ ± 0  50 💤 ±0  0 ❌ ±0 
7 750 runs   - 28  7 690 ✅  - 28  60 💤 ±0  0 ❌ ±0 

Results for commit e120bea. ± Comparison against base commit 623dae4.

♻️ This comment has been updated with latest results.

@mcollovati mcollovati marked this pull request as draft October 2, 2024 10:03
Copy link

sonarcloud bot commented Oct 2, 2024

@mcollovati mcollovati marked this pull request as ready for review October 2, 2024 12:57
@ZheSun88 ZheSun88 merged commit 27d1f92 into main Oct 7, 2024
27 checks passed
@ZheSun88 ZheSun88 deleted the chore/gradle-run-tests-with-jdk-gt-17 branch October 7, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle test is not running on JDK 20
3 participants