chore: put auto layout behind feature flag #20119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps `spring.boot.version` from 3.3.3 to 3.3.4. Updates `org.springframework.boot:spring-boot-starter-web` from 3.3.3 to 3.3.4 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.3.3...v3.3.4) Updates `org.springframework.boot:spring-boot-dependencies` from 3.3.3 to 3.3.4 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.3.3...v3.3.4) Updates `org.springframework.boot:spring-boot-maven-plugin` from 3.3.3 to 3.3.4 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.3.3...v3.3.4) Updates `org.springframework.boot:spring-boot-devtools` from 3.3.3 to 3.3.4 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.3.3...v3.3.4) Updates `org.springframework.boot:spring-boot-starter-mustache` from 3.3.3 to 3.3.4 - [Release notes](https://github.com/spring-projects/spring-boot/releases) - [Commits](spring-projects/spring-boot@v3.3.3...v3.3.4) --- updated-dependencies: - dependency-name: org.springframework.boot:spring-boot-starter-web dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.springframework.boot:spring-boot-dependencies dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.springframework.boot:spring-boot-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.springframework.boot:spring-boot-devtools dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.springframework.boot:spring-boot-starter-mustache dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: close overlay drawer on click Close the overlay drawer even when clicking on same link and no actual navigation happens. Fixes #19823 * reset fromAnchor for navigation This in case the flag has for some reason not been reset after a click.
On CI system the test randomly fails because the GC seems not to clean up ComponentLocator memory within the 5 milliseconds. However, running the test in isolation works fine. This change increases the delay between the GC requests to try to make the test more reliable.
Node 22 will become LTS well before the 24.6 release
* chore: More detailed logging for ignored handling Make log more detailed for ignored invocation handle. * Add javadoc unify log.
* fix: Validate Control Center feature when used Changes production build info to validate Control Center feature only when VaadinActuatorEndpoint is in the class path. Class will be included with `control-center-starter` Vaadin platform dependency. Fixes: #20013 * chore: formatting
* chore(deps): bump commons-io:commons-io from 2.16.1 to 2.17.0 Bumps commons-io:commons-io from 2.16.1 to 2.17.0. --- updated-dependencies: - dependency-name: commons-io:commons-io dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * chore: bump open 8.5.0.3 * chore: bump license checker to 1.13.0.beta2 * chore: upgrade license-checker to 1.13.0.beta3 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tomi Virtanen <[email protected]> Co-authored-by: Zhe Sun <[email protected]>
This is useful in a couple of cases: 1. Browser launcher is not enabled 2. Browser launcher does not work 3. You closed the browser tab and a new one is not automatically reopened when you restart
* chore: show warning when LC is missing in a DAU build In a DAU build, checks if license-checker will be present at runtime and prints a warning message with instructions to fix the configuration if it the dependency is missing. * Apply suggestions from code review Co-authored-by: Tomi Virtanen <[email protected]> --------- Co-authored-by: Tomi Virtanen <[email protected]>
Ensures that root output element added for React router in Flow.tsx doesn't accidentally change the main layout with CSS rules targeting it. Fixes: #19871
#20043) Bumps [com.google.guava:guava](https://github.com/google/guava) from 33.3.0-jre to 33.3.1-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [com.helger:ph-css](https://github.com/phax/ph-css) from 7.0.2 to 7.0.3. - [Release notes](https://github.com/phax/ph-css/releases) - [Commits](phax/ph-css@ph-css-parent-pom-7.0.2...ph-css-parent-pom-7.0.3) --- updated-dependencies: - dependency-name: com.helger:ph-css dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 4.0.1 to 4.0.2. - [Release notes](https://github.com/codehaus-plexus/plexus-utils/releases) - [Commits](codehaus-plexus/plexus-utils@plexus-utils-4.0.1...plexus-utils-4.0.2) --- updated-dependencies: - dependency-name: org.codehaus.plexus:plexus-utils dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ontend/* (#20032) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.2.7 to 5.4.6. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.4.6/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.6/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mikael Grankvist <[email protected]>
Bumps [rollup](https://github.com/rollup/rollup) to 4.22.4 and updates ancestor dependency [@web/test-runner](https://github.com/modernweb-dev/web/tree/HEAD/packages/test-runner). These dependencies need to be updated together. Updates `rollup` from 2.79.1 to 4.22.4 - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.79.1...v4.22.4) Updates `@web/test-runner` from 0.15.1 to 0.19.0 - [Release notes](https://github.com/modernweb-dev/web/releases) - [Changelog](https://github.com/modernweb-dev/web/blob/master/packages/test-runner/CHANGELOG.md) - [Commits](https://github.com/modernweb-dev/web/commits/@web/[email protected]/packages/test-runner) --- updated-dependencies: - dependency-name: rollup dependency-type: indirect - dependency-name: "@web/test-runner" dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Update the page title after navigation has ended to not have the wrong title in history. Fixes #19868
…0055) Bumps [com.mycila:license-maven-plugin](https://github.com/mathieucarbou/license-maven-plugin) from 4.5 to 4.6. - [Release notes](https://github.com/mathieucarbou/license-maven-plugin/releases) - [Commits](mathieucarbou/license-maven-plugin@license-maven-plugin-4.5...license-maven-plugin-4.6) --- updated-dependencies: - dependency-name: com.mycila:license-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps org.codehaus.cargo:cargo-maven3-plugin from 1.10.14 to 1.10.15. --- updated-dependencies: - dependency-name: org.codehaus.cargo:cargo-maven3-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…20068) Bumps [de.skuzzle.enforcer:restrict-imports-enforcer-rule](https://github.com/skuzzle/restrict-imports-enforcer-rule) from 2.5.0 to 2.6.0. - [Release notes](https://github.com/skuzzle/restrict-imports-enforcer-rule/releases) - [Changelog](https://github.com/skuzzle/restrict-imports-enforcer-rule/blob/master/CHANGELOG_LEGACY.md) - [Commits](skuzzle/restrict-imports-enforcer-rule@v2.5.0...v2.6.0) --- updated-dependencies: - dependency-name: de.skuzzle.enforcer:restrict-imports-enforcer-rule dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from 1.15.1 to 1.15.2. - [Release notes](https://github.com/raphw/byte-buddy/releases) - [Changelog](https://github.com/raphw/byte-buddy/blob/master/release-notes.md) - [Commits](raphw/byte-buddy@byte-buddy-1.15.1...byte-buddy-1.15.2) --- updated-dependencies: - dependency-name: net.bytebuddy:byte-buddy dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: add MenuConfiguration New public API for building application menu: adds `MenuConfiguration`, `MenuOptions` and `MenuOption` where `MenuConfiguration` is the main entry point to access menu data to build main menu. Fixes: #20063 * chore: renamed classes and removed MenuOptions Renamed MenuOption to MenuEntry. * chore: updated javadocs * chore: moved MenuRegistry to internal package Removed Serializable from MenuConfiguration. * chore: added javadoc and deprecated MenuData constructor * chore: use new constructor * chore: make MenuConfiguration final
Bumps [io.dropwizard.metrics:metrics-core](https://github.com/dropwizard/metrics) from 4.2.27 to 4.2.28. - [Release notes](https://github.com/dropwizard/metrics/releases) - [Commits](dropwizard/metrics@v4.2.27...v4.2.28) --- updated-dependencies: - dependency-name: io.dropwizard.metrics:metrics-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: Accesscontrolled layout Make Flow (a)Layout linking dynamic. Add access checking for route Layout. Part of #20097 * Fix tests * format * Take into account navigation targeting RouteAlias * Add test for multiple RouteAliases fix multiple aliases annotation present * add messages for alias false checks. * Add access tests for automatic layouts * Log denied layout name. only note in exception that it is a layout * Use existing access test classes * Fix review comments. Remove layout name from deny context.
* fix: reload route configuration upon layout changes When a [At]Layout annotated class is modified, the changes are not propagated to the route registry after hotswap happens. This change updates Route registry layouts configuration and re-registers routes potentially impacted by the change to apply the new settings. It also checks the route target chain for active UIs in order to trigger a page refresh if the layout changes should be applied. Fixes #20111 * clean up and remove useless duplicated test * revert change * handle layout changes for Hilla views * fix assertion parameters oreder * remove commented code
* fix: HMR for translation files * Clears resource bundle cache on translation resource redeployment * Fires a HMR event to the browser when translations are reloaded Limitation: Only supports DefaultI18NHandler where the paths are known. If you have a custom I18N handler, you might need a custom HMR supporting HotswapListener. For #20118 Requires vaadin/hilla#2795 to fully fix the issue * format * trigger Flow UIs refresh * flow support * detect correct refresh stragety per UI --------- Co-authored-by: Marco Collovati <[email protected]>
Set the DAU cookie as secure, if the http request is secure. Same as for JWT cookie.
Creates ClassFinder once per mojo execution, preventing eccessive and useless scans. Fixes #19874
Refactor hotswap logic and tests to align with changes introduced by #20120.
`MenuEntry#exclude` is always false with `MenuConfiguration`.
…0116) * chore: allow running gradle plugin tests with JDK greater that 17 Currently, running gradle plugin tests with a JDK greater than 17, and not having 17 installed on the system, fails because kotlin is configured to use a JDK 17 toolchain. This change replaces the toolchain setting for kotlin, pinning insted the jvmTarget compiler configuration to 17. This is an alternative way to fix #17574. * bump spring boot plugin
Reintroduces static methods used by Hilla in FlowModeAbstractMojo, preserving the ClassFinder creation improvements for Flow mojos.
* fix: navigatin to client view from server Navigation to the client view using server navigate should work normally and not try to add layout for non layout client view. * remove class used for hilla compatibility
Co-authored-by: Mikhail Shabarov <[email protected]>
* chore: Bump Polymer * Fix test
) Bumps [org.apache.maven.plugins:maven-failsafe-plugin](https://github.com/apache/maven-surefire) from 3.5.0 to 3.5.1. - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.5.0...surefire-3.5.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-failsafe-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marco Collovati <[email protected]>
Bumps org.ow2.asm:asm from 9.7 to 9.7.1. --- updated-dependencies: - dependency-name: org.ow2.asm:asm dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Artur <[email protected]>
) Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.5.0 to 3.5.1. - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.5.0...surefire-3.5.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-surefire-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
caalador
force-pushed
the
feature-flag/layout-and-menu-feature-flag
branch
from
d1e0748
to
c4d92c3
Compare
|
|
Auto layout feature is shipped normally with 24.5, so this isn't needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.