fix(form): initialize arrays when receiving items (#2959) (CP: 24.6) (#…

…3126) fix(form): initialize arrays when receiving items (#2959) * fix(form): initialize arrays when receiving items Fixes #2949 * fix(lit-form): make it build * test(lit-form): make linter happy --------- Co-authored-by: Anton Platonov <[email protected]> Co-authored-by: Vlad Rindevich <[email protected]> Co-authored-by: Luciano Vernaschi <[email protected]>
vaadin · Jan 13, 2025 · ee0e161 · ee0e161
1 parent ccb2ef2
commit ee0e161
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/packages/ts/lit-form/src/BinderNode.ts b/packages/ts/lit-form/src/BinderNode.ts
@@ -267,7 +267,7 @@ export class BinderNode<M extends AbstractModel = AbstractModel> extends EventTa
   }
 
   set value(value: Value<M> | undefined) {
-    this.initializeValue();
+    this.initializeValue(true);
     this.#setValueState(value, undefined);
   }
 

diff --git a/packages/ts/lit-form/test/Binder.test.ts b/packages/ts/lit-form/test/Binder.test.ts
@@ -5,7 +5,7 @@ import { customElement } from 'lit/decorators.js';
 import sinon from 'sinon';
 import sinonChai from 'sinon-chai';
 // API to test
-import { Binder, type BinderConfiguration } from '../src/index.js';
+import { Binder, type BinderConfiguration, m } from '../src/index.js';
 import {
   type Employee,
   EmployeeModel,
@@ -302,6 +302,21 @@ describe('@vaadin/hilla-lit-form', () => {
         assert.isTrue('supervisor' in binder.value);
       });
 
+      it('should support optional array', async () => {
+        const arrayBinderNode = binder.for(binder.model.colleagues);
+        assert.isUndefined(arrayBinderNode.value);
+        assert.isUndefined(arrayBinderNode.defaultValue);
+
+        arrayBinderNode.value = [EmployeeModel.createEmptyValue()];
+        const [itemModel] = m.items(arrayBinderNode.model);
+        assert.deepEqual(binder.for(itemModel).value, expectedEmptyEmployee);
+        assert.deepEqual(arrayBinderNode.defaultValue, []);
+        assert.isTrue(arrayBinderNode.dirty);
+
+        await binder.validate();
+        assert.isFalse(binder.invalid);
+      });
+
       it('should initialize parent optional on child binderNode access', () => {
         binder.for(binder.model.supervisor.supervisor);