Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(aot): do not delete args file #3120

Merged
merged 4 commits into from
Jan 9, 2025
Merged

chore(aot): do not delete args file #3120

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0dd526
don't delete aot args file each time
cromoteca Jan 7, 2025
3f7f2bd
Merge branch 'main' into do-not-delete-aot-args-file
cromoteca Jan 9, 2025
7dcea03
Merge branch 'main' into do-not-delete-aot-args-file
taefi Jan 9, 2025
db35c41
Merge branch 'main' into do-not-delete-aot-args-file
taefi Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...ages/java/engine-core/src/main/java/com/vaadin/hilla/engine/AotBrowserCallableFinder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ private static Path generateAotArtifacts(
engineConfiguration.getArtifactId()).toList();

var argsFile = engineConfiguration.getBuildDir()
.resolve("aot-args-" + System.currentTimeMillis() + ".txt");
.resolve("hilla-aot-args.txt");
Files.write(argsFile, settings);

var javaExecutable = ProcessHandle.current().info().command()
Expand All @@ -92,9 +92,7 @@ private static Path generateAotArtifacts(
int exitCode = new ProcessBuilder().inheritIO()
.command(javaExecutable, "@" + argsFile).start().waitFor();

if (exitCode == 0) {
Files.delete(argsFile);
} else {
if (exitCode != 0) {
LOGGER.error(
SPRING_AOT_PROCESSOR + " exited with code: " + exitCode);
}
Expand Down
Loading