fix(binder): convert property paths in arrays to dot notation #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3157 +/- ##
=======================================
Coverage 92.65% 92.65%
=======================================
Files 85 85
Lines 3187 3187
Branches 778 778
=======================================
Hits 2953 2953
Misses 182 182
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…correctly-with-array-form-binding
platosha
approved these changes
Jan 17, 2025
…correctly-with-array-form-binding
|
Lodin
requested changes
Jan 17, 2025
Lodin
approved these changes
Jan 17, 2025
platosha
deleted the
fix/3099/Server-side-validators-not-working-correctly-with-array-form-binding
branch
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
Convert to dot notation on the fly Co-authored-by: Anton Platonov <[email protected]>
cromoteca
added a commit
that referenced
this pull request
Jan 20, 2025
… (CP: 24.6) (#3163) fix(binder): convert property paths in arrays to dot notation (#3157) Convert to dot notation on the fly Co-authored-by: Luciano Vernaschi <[email protected]> Co-authored-by: Anton Platonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the square bracket array syntax comes directly from Java valdiation, I preferred not to touch at the generated exception messages.
Instead, the binder now converts the notation on the fly when parsing the error message, so that it will work in the form.
Fixes #3099