Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make default value optional for ValueSignal #3160

Merged
merged 16 commits into from
Jan 28, 2025

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Jan 16, 2025

Description

Fixes #2746

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 97.61905% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.84%. Comparing base (6de563d) to head (7f9f5f4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ts/generator-plugin-signals/src/SignalProcessor.ts 97.61% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3160      +/-   ##
==========================================
+ Coverage   92.65%   92.84%   +0.19%     
==========================================
  Files          85       85              
  Lines        3187     3328     +141     
  Branches      778      800      +22     
==========================================
+ Hits         2953     3090     +137     
- Misses        182      186       +4     
  Partials       52       52              
Flag Coverage Δ
unittests 92.84% <97.61%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taefi taefi marked this pull request as ready for review January 23, 2025 20:19
@taefi taefi changed the title feat!: make default value optional for ValueSignal feat: make default value optional for ValueSignal Jan 27, 2025
Co-authored-by: Luciano Vernaschi <[email protected]>
@taefi taefi requested a review from cromoteca January 27, 2025 14:04
@taefi taefi merged commit da0bb75 into main Jan 28, 2025
15 checks passed
@taefi taefi deleted the taefi/value-signal-optional-default branch January 28, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Full-stack Signals] make default value optional
2 participants