Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generator): throw on overloaded methods #3168

Closed
wants to merge 2 commits into from
Closed

feat(generator): throw on overloaded methods #3168

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c8a238
Throw on overloaded methods
cromoteca Jan 20, 2025
d6fdbba
Merge branch 'main' into feat/generator/throw-on-overloaded-methods
cromoteca Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...-plugin-backbone/src/main/java/com/vaadin/hilla/parser/plugins/backbone/MethodPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package com.vaadin.hilla.parser.plugins.backbone;

import java.util.Optional;
import java.util.function.Function;
import java.util.stream.Collectors;

import org.jspecify.annotations.NonNull;

Expand Down Expand Up @@ -81,7 +83,13 @@ public NodeDependencies scan(@NonNull NodeDependencies nodeDependencies) {
var endpointCls = (ClassInfoModel) node.getSource();
var methodNodes = endpointCls.getMethods().stream()
.filter(MethodInfoModel::isPublic)
.<Node<?, ?>> map(MethodNode::of);
.collect(Collectors.toMap(MethodInfoModel::getName,
Function.identity(), (m1, m2) -> {
throw new BackbonePluginException(String.format(
"Overloaded methods are not supported (method '%s' in class '%s')",
m1.getName(), endpointCls.getName()));
}))
.values().stream().<Node<?, ?>> map(MethodNode::of);
return nodeDependencies.appendChildNodes(methodNodes);
}

Expand Down
Loading