Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): do not propagate NonNullApi to other packages #3235

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

cromoteca
Copy link
Contributor

Reset the requiredByContext value of nullability to reflect the class that contains the property.

Fixes #2406

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.91%. Comparing base (d4be98d) to head (27a2b69).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3235   +/-   ##
=======================================
  Coverage   86.91%   86.91%           
=======================================
  Files         118      118           
  Lines        8192     8192           
  Branches     1259     1259           
=======================================
  Hits         7120     7120           
  Misses       1058     1058           
  Partials       14       14           
Flag Coverage Δ
unittests 86.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cromoteca cromoteca marked this pull request as draft February 13, 2025 17:34
@cromoteca cromoteca marked this pull request as ready for review February 14, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller applies @NonNullApi recursively to all data regardless of origin
1 participant