Skip to content

Commit

Permalink
chore: remove unnecessary dependency to hybrid dev module
Browse files Browse the repository at this point in the history
vaadin-dev-bundle requires vaadin-hybrid-dev-bundle only to extract
the hybrid package-lock.json file. It is unnecessary to have the
hybrid bundle module as a project dependency, since the unpack
goal of maven-dependency-plugin don't need the project to download
the artifact. Moreover, having the hybrid bundle as project dependency
can cause issue during bundle creation, if the flow maven plugin
finds the stats.json from the hybrid bundle.
  • Loading branch information
mcollovati committed Oct 24, 2024
1 parent 1f75dd6 commit bcc87e3
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions scripts/generator/templates/template-dev-bundle-pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,6 @@
</properties>

<dependencies>
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>vaadin-hybrid-dev-bundle</artifactId>
<version>${project.version}</version>
<optional>true</optional>
</dependency>
<dependency>
<groupId>com.vaadin</groupId>
<artifactId>vaadin-internal</artifactId>
Expand Down

0 comments on commit bcc87e3

Please sign in to comment.