Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove ui-tests dependency #6926

Merged
merged 3 commits into from
Oct 25, 2024
Merged

chore: Remove ui-tests dependency #6926

merged 3 commits into from
Oct 25, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Oct 24, 2024

The dependency is commercial so it cannot be a dependency of vaadin-dev. We cannot move it to be a dependency of vaadin either as it then will end up in the production artifacts.

Additionally it seems this is a dependency that should not be used in end user projects, at least not right now, so having it outside the platform is fine.

Fixes #6915

Copy link

github-actions bot commented Oct 24, 2024

Dependencies Report

  • 🚫 Vulnerabilities:

  • 🟠 Known Vulnerabilities:

    • Vulnerabilities in: pkg:npm/[email protected] [CVE-2024-34394, CVE-2024-34393] (osv-scan)
      👌 This is coming from the tools, @cyclonedx/cyclonedx, we have used for sbom module, FP for us.
      ·
    • Vulnerabilities in: pkg:maven/com.fasterxml.jackson.core/[email protected] [CVE-2023-35116] (owasp)
      👌 Not a valid CVE report based on the vendor analysis and research
      · cpe:2.3:a:fasterxml:jackson-databind::::::::
    • Vulnerabilities in: pkg:maven/me.friwi/jcef-api@jcef-af53d63%2Bcef-104.4.23%2Bg46ae630%2Bchromium-104.0.5112.102 [CVE-2024-21639, CVE-2024-21640] (owasp)
      👌 Wait for the update from the jcefmaven community. Meanwhile the swing-kit is supposed to be used with fixed websites and not to browse the internet, we have a check for that, so the only possible attacker would be the same person that created the swing application, aka our customer devs. so this vulnerability is not classified by us as critical issue
      · cpe:2.3:a:chromiumembedded:chromium_embedded_framework::::::::
  • 📔 No License Issues

  • 🟠 Changes in 24.6-SNAPSHOT since V24.6.0.alpha1

    • 31 packages removed (31 external, 0 vaadin)
    • 1 packages added (1 external, 0 vaadin)
    • 17 packages modified (17 external, 0 vaadin)
    • 1012 packages same (787 external, 225 vaadin)

[Click for more Details]

@Artur- Artur- changed the title chore: Remove ui-tests chore: Remove ui-tests dependency and mark test generation as temporarily unavailable Oct 25, 2024
@Artur- Artur- changed the title chore: Remove ui-tests dependency and mark test generation as temporarily unavailable chore: Remove ui-tests dependency Oct 25, 2024
@ZheSun88
Copy link
Contributor

as ui-tests has been dropped from copilot, let us take this PR in 24.5.2.

@ZheSun88 ZheSun88 enabled auto-merge (squash) October 25, 2024 09:41
@ZheSun88 ZheSun88 merged commit 2e9e8d0 into main Oct 25, 2024
2 of 3 checks passed
@ZheSun88 ZheSun88 deleted the remove-ui-tests branch October 25, 2024 10:11
@vaadin-bot
Copy link
Contributor

Hi @Artur- , this commit cannot be picked to 24.5 by this bot, can you take a look and pick it manually?

ZheSun88 added a commit that referenced this pull request Oct 25, 2024
ZheSun88 added a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apache 2.0 licensed vaadin-core includes Commercial licensed ui-tests
3 participants