Upgrade selenium to 4.14 (#1687)

* Update Selenium to 4.13 (#1683) * Update Selenium to 4.13 * Use `addArguments` instead of `setHeadless` This was instructed in deprecation notes of previous versions. * chore: Upgrade Selenium to 4.14 (#1685) --------- Co-authored-by: Guille <[email protected]> Co-authored-by: Mikhail Shabarov <[email protected]>
vaadin · Oct 20, 2023 · e523269 · e523269
1 parent aec16b3
commit e523269
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/pom.xml b/pom.xml
@@ -33,7 +33,7 @@
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
         <Implementation-Version>${project.version}</Implementation-Version>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-        <selenium.version>4.12.0</selenium.version>
+        <selenium.version>4.14.0</selenium.version>
         <maven.compiler.source>17</maven.compiler.source>
         <maven.compiler.target>17</maven.compiler.target>
         <spring.version>6.0.9</spring.version>

diff --git a/vaadin-testbench-shared/pom.xml b/vaadin-testbench-shared/pom.xml
@@ -162,10 +162,6 @@
             <groupId>org.seleniumhq.selenium</groupId>
             <artifactId>selenium-http</artifactId>
         </dependency>
-        <dependency>
-            <groupId>org.seleniumhq.selenium</groupId>
-            <artifactId>selenium-http-jdk-client</artifactId>
-        </dependency>
 
         <dependency>
             <groupId>org.slf4j</groupId>

diff --git a/vaadin-testbench-shared/src/main/java/com/vaadin/testbench/parallel/setup/LocalDriver.java b/vaadin-testbench-shared/src/main/java/com/vaadin/testbench/parallel/setup/LocalDriver.java
@@ -66,7 +66,9 @@ static public WebDriver createDriver(
                 FirefoxProfile profile = new FirefoxProfile(profileDir);
                 options.setProfile(profile);
             }
-            options.setHeadless(Parameters.isHeadless());
+            if (Parameters.isHeadless()) {
+                options.addArguments("-headless");
+            }
             driver = new FirefoxDriver(options);
         } else if (BrowserUtil.isChrome(desiredCapabilities)) {
             // Tells chrome not to show warning
@@ -75,7 +77,10 @@ static public WebDriver createDriver(
             // #14319
             ChromeOptions options = new ChromeOptions();
             options.addArguments("--test-type ");
-            options.setHeadless(Parameters.isHeadless());
+
+            if (Parameters.isHeadless()) {
+                options.addArguments("--headless=new");
+            }
             driver = new ChromeDriver(options);
         } else if (BrowserUtil.isSafari(desiredCapabilities)) {
             driver = new SafariDriver();